add description and examples for $id keyword (#105)
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses #47. It is built upon the changes proposed in #45 and implements the suggested modifications --------- Co-authored-by: Juan Cruz Viotti <[email protected]>
jviotti
approved these changes
Feb 6, 2024
|
BTW, if you are up for it, you should consider upstreaming the definitions of schemas, schema resources, and schema objects to the JSON Schema official glossary cc @Julian |
|
Later, if they are the glossary, we can probably explain them less here and link there instead? |
Co-authored-by: Juan Cruz Viotti <[email protected]>
Co-authored-by: Juan Cruz Viotti <[email protected]>
Sure, I'm happy to help with that. Thanks for the suggestion! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #47.
It is built upon the changes requested in #45 and implements the suggested modifications
Also let me know what you think about this card.
