-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description and examples for maxLength
keyword
#110
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e682588
add description and examples for enum keyword
AgniveshChaubey 2e77f7b
add dialect version to examples
AgniveshChaubey b01d2ce
add description and examples for const keyword
AgniveshChaubey 31acac3
add 'Example' heading
AgniveshChaubey 58b3dc8
Merge branch 'main' into keyword-const
AgniveshChaubey e20481e
remove type keyword
AgniveshChaubey da10468
add description and examples for minLength keyword
AgniveshChaubey 295d758
add description and examples for maxLength keyword
AgniveshChaubey 8eec482
enhance description
AgniveshChaubey b20b859
fix indentation
AgniveshChaubey 5006f12
Merge branch 'main' into keyword-maxLength
AgniveshChaubey cce444f
Update minLength.markdown
AgniveshChaubey 1bac0ed
Merge branch 'main' into keyword-maxLength
AgniveshChaubey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you mention it (which is a good point), I think it'd be good exemplifying this. I guess you can provide an instance that consists of unicode characters in the UTF-16 and/or UTF-32 range, showing that it still validates against
maxLength
based on the number of characters.I recall seeing some examples of this in the JSON Schema Test Suite