Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides toc refactor #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ashutosh-src
Copy link
Contributor

@ashutosh-src ashutosh-src commented Apr 2, 2025

refactor the guides toc in order, no classification

@ashutosh-src ashutosh-src self-assigned this Apr 2, 2025
@ashutosh-src ashutosh-src requested a review from jsimnz April 2, 2025 02:09
Copy link

cloudflare-workers-and-pages bot commented Apr 2, 2025

Deploying docs-source-network with  Cloudflare Pages  Cloudflare Pages

Latest commit: 815686c
Status: ✅  Deploy successful!
Preview URL: https://d954afcf.docs-source-network.pages.dev
Branch Preview URL: https://ashutosh-guides-refactor-toc.docs-source-network.pages.dev

View logs

@ashutosh-src ashutosh-src force-pushed the ashutosh/guides-refactor-toc branch from 44c6ba2 to 81b51b8 Compare April 2, 2025 20:08
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this structure makes sense. We want to track internally which docs is part of which category of documentation, but we don't need to explicitly label each of these guides as either procedural or conceptual

@ashutosh-src
Copy link
Contributor Author

I don't think this structure makes sense. We want to track internally which docs is part of which category of documentation, but we don't need to explicitly label each of these guides as either procedural or conceptual

@jsimnz In that case I will remove the classification but keep the order as is. Thanks

@ashutosh-src ashutosh-src requested a review from jsimnz April 3, 2025 15:40
@ashutosh-src ashutosh-src force-pushed the ashutosh/guides-refactor-toc branch from fe96126 to 8d50cfa Compare April 3, 2025 15:41
updated

removed structure
@ashutosh-src ashutosh-src force-pushed the ashutosh/guides-refactor-toc branch from 8d50cfa to 815686c Compare April 3, 2025 15:42
Copy link
Contributor

@iverc iverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ashutosh-src
Copy link
Contributor Author

@jsimnz - pls approve, I have removed the 2nd level classification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants