This repository was archived by the owner on Oct 18, 2023. It is now read-only.
Feat/case #2
Draft
Feat/case #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
espoal
commented
Jul 14, 2023
| @@ -1,3 +1,48 @@ | |||
| import { CaseToCase } from 'case-to-case' | |||
espoal
commented
Jul 14, 2023
| @@ -1,4 +1,4 @@ | |||
| import { Controller } from '@nestjs/common'; | |||
|
|
|||
| @Controller('<%= dasherize(name) %>') | |||
| @Controller('<%= name %>') | |||
There was a problem hiding this comment.
I expect the name to be passed with the correct casing option so dasherize shouldn't be needed anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the second of a multi PR effort aiming at supporting custom name casing conventions, as detailed nestjs/nest-cli#462.
@nestjs/schematicsto accept a caseType option when generating a controller.--caseoption to the CLI so that it can be correctly passed to the schematic generator.controllersFor now I decided to support only controllers, to reduce the changes size and make reviewing easier. If the approach will be approved I will make sure to extend it to other objects and to add more tests.
This PR has been sponsored by South Pole. South pole is currently hiring, make sure to check the available positions!.
Open questions
TBD
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
@nestjs/schematicsuseskebab-case, as mentioned here.Issue Number: 462
What is the new behavior?
A new
SchematicOptioncalledcaseTypewill allow us to specify a case convention and the output will be formatted accordingly.Does this PR introduce a breaking change?
Other information