Skip to content

Update train.py #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielvalencia95
Copy link

Ensure the use of patience for early stopping

Ensure the use of patience for early stopping
@sovit-123
Copy link
Owner

Hello @danielvalencia95 I think the command line argument already employs a default value of 10 for early stopping. I think the change you made might not be necessary. Please let me know if I am missing something.

@danielvalencia95
Copy link
Author

Hello @sovit-123 the default value works, but with a different values the early stopping don´t work.

Also, i made another PR for the eval.py

@sovit-123
Copy link
Owner

That's a bit odd. I will surely test it out and if necessary will merge your code.
Thanks.

@danielvalencia95
Copy link
Author

Hello @sovit-123

Ok, please also review my PR about eval.py

@sovit-123
Copy link
Owner

Will do that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants