Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty fix for RT-5289 #33225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Nov 8, 2024

About the PR

Adds dotnet build -c Release RobustToolbox\Robust.Client.Injectors in all the client batch files to ensure we have RELEASE Robust.Client.Injectors

This frequently happens on people who just cloned the repo and never built release.

space-wizards/RobustToolbox#5289 should fix this but it has been stuck for a while seemingly nowhere and I want a temporary fix for now

Also adds pause to let you see any errors.

Requirements

@github-actions github-actions bot added the No C# For things that don't need code. label Nov 8, 2024
@VasilisThePikachu VasilisThePikachu changed the title Dirty fix for https://github.com/space-wizards/RobustToolbox/pull/5289 Dirty fix for RT-5289 Nov 8, 2024
@0x6273
Copy link
Contributor

0x6273 commented Nov 13, 2024

Also adds pause to let you see any errors.

Can you make it pause only if you launch the bat from explorer? I imagine most people will run these directly from a terminal and pausing is just annoying in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants