feat: add membership check #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/subset
branch
9 times, most recently
from
afda721 to
fb13f72
Compare
iajoiner
force-pushed
the
feat/subset
branch
6 times, most recently
from
72a4eaf to
cfa7a3c
Compare
iajoiner
force-pushed
the
feat/subset
branch
2 times, most recently
from
dbff583 to
9908847
Compare
iajoiner
commented
Jan 7, 2025
iajoiner
force-pushed
the
feat/subset
branch
5 times, most recently
from
a4e87a5 to
5ff2063
Compare
JayWhite2357
reviewed
Jan 9, 2025
JayWhite2357
reviewed
Jan 9, 2025
JayWhite2357
reviewed
Jan 9, 2025
crates/proof-of-sql/src/sql/proof_gadgets/membership_check_test.rs
Outdated
Show resolved
Hide resolved
iajoiner
force-pushed
the
feat/subset
branch
6 times, most recently
from
d7c477b to
e7047a8
Compare
iajoiner
force-pushed
the
feat/subset
branch
3 times, most recently
from
ec3558e to
92252bd
Compare
iajoiner
force-pushed
the
feat/subset
branch
3 times, most recently
from
2186ee5 to
99d5ac8
Compare
Comment on lines
18
to
23
| multiplicities: &[usize], | ||
| alloc: &'a Bump, | ||
| ) { | ||
| let casted_multiplicities: Vec<i128> = multiplicities.iter().map(|&x| x as i128).collect(); | ||
| let alloc_multiplicities = alloc.alloc_slice_copy(casted_multiplicities.as_slice()); | ||
| builder.produce_intermediate_mle(alloc_multiplicities as &[_]); |
There was a problem hiding this comment.
Suggested change
| multiplicities: &[usize], | |
| alloc: &'a Bump, | |
| ) { | |
| let casted_multiplicities: Vec<i128> = multiplicities.iter().map(|&x| x as i128).collect(); | |
| let alloc_multiplicities = alloc.alloc_slice_copy(casted_multiplicities.as_slice()); | |
| builder.produce_intermediate_mle(alloc_multiplicities as &[_]); | |
| multiplicities: &'a [u64], | |
| ) { | |
| builder.produce_intermediate_mle(multiplicities); |
There was a problem hiding this comment.
Same thing in final_round_evaluate_membership_check as well.
Comment on lines
45
to
46
| let input_ones = alloc.alloc_slice_fill_copy(num_rows, true); | ||
| let candidate_ones = alloc.alloc_slice_fill_copy(candidate_num_rows, true); |
There was a problem hiding this comment.
Making these parameters allows them to be reused, which is likely, saving memory and sumcheck perf.
crates/proof-of-sql/src/sql/proof_gadgets/membership_check_test.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/sql/proof_gadgets/membership_check_test.rs
Outdated
Show resolved
Hide resolved
iajoiner
force-pushed
the
feat/subset
branch
3 times, most recently
from
5b96478 to
0e8faaf
Compare
JayWhite2357
approved these changes
Jan 15, 2025
|
🎉 This PR is included in version 0.66.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.FirstRoundBuilderto produce MLEs #417Rationale for this change
The membership check gadget is a crucial component of joins. Hence we need to add it.
What changes are included in this PR?
Are these changes tested?
Yes.