Improve product page#337
Merged
takumiando merged 2 commits intospacecubics:mainfrom Apr 2, 2026
Merged
Conversation
Remove the unused `bg` argument from `product_display()`. The shortcode no longer uses `bg` to set a background image, so drop it from both the template and its call sites. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Add the product page link (`details_link`) to the image so visitors can click the product image to open the product page. This improves usability because, in the previous version, only the arrow in the orange circle was linked. `img_link` is no longer referenced in the template, so remove it as well. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
yashi
force-pushed
the
improve-product-page
branch
from
49f061f to
30d892b
Compare
takumiando
approved these changes
Apr 2, 2026
Member
Author
|
hmm... I was expecting no visual changes... oops I didn't submit this comment... There was a visual diff and I was fixing.... |
Member
Author
|
The commit log is half baked. I should add:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit logs.