Skip to content

Migrate system tests to use GRPC V2 API #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Migrate system tests to use GRPC V2 API #6696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e52fca
Move v1 API into dedicated package
fasmat Feb 5, 2025
cc83a5d
Streams are generally on the private connection
fasmat Feb 5, 2025
0dd999d
Fix getNonce request
fasmat Feb 6, 2025
1d85fa8
Add more context to errors
fasmat Feb 6, 2025
91f57d0
Fix layer streaming for layers with empty blocks
fasmat Feb 6, 2025
79c7c07
LayerStream always starts from 0
fasmat Feb 6, 2025
cf3b7cc
Improve logging
fasmat Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion node/node_identities_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ func setupAppWithKeys(tb testing.TB, data ...[]byte) (*App, *observer.ObservedLo
)))
cfg := getTestConfig(tb)
app := New(WithLog(log.NewFromLog(logger)), WithConfig(&cfg))
app.Config.DataDirParent = tb.TempDir()
if len(data) == 0 {
return app, observedLogs
}
Expand Down
4 changes: 4 additions & 0 deletions sql/layers/layers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,10 @@
stmt.ColumnBytes(4, layer.StateHash[:])
stmt.ColumnBytes(5, layer.AggregatedHash[:])

if layer.AppliedBlock.IsEmpty() {
return true
}

Check warning on line 390 in sql/layers/layers.go

View check run for this annotation

Codecov / codecov/patch

sql/layers/layers.go#L389-L390 

Added lines #L389 - L390 were not covered by tests

inner := types.InnerBlock{}
_, err := codec.DecodeFrom(stmt.ColumnReader(7), &inner)
if err != nil {
Expand Down
9 changes: 8 additions & 1 deletion systest/tests/checkpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ func TestCheckpoint(t *testing.T) {
ctx, cancel := context.WithDeadline(tctx, deadline)
defer cancel()
require.NoError(t, sendTransactions(ctx, tctx.Log.Desugar(), cl, first, stop, receiver, 1, 100))
require.NoError(t, waitLayer(tctx, cl.Client(0), snapshotLayer))

layerTime := cl.Genesis().Add(time.Duration(snapshotLayer) * layerDuration)
tctx.Log.Debugw("waiting for layer", "layer", snapshotLayer, "layer time", layerTime)
select {
case <-tctx.Done():
require.FailNow(t, "test context is done")
case <-time.After(time.Until(layerTime)):
}

tctx.Log.Debugw("getting account balances")
before, err := getBalance(tctx, cl, snapshotLayer)
Expand Down
Loading
Loading