Remove old BMC services #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivalaginja
force-pushed
the
feature/remove_old_bmc_services
branch
from
5a5c887 to
1de67ae
Compare
ivalaginja
force-pushed
the
feature/remove_old_bmc_services
branch
from
d6c4c59 to
1325c6e
Compare
ivalaginja
force-pushed
the
feature/remove_old_bmc_services
branch
from
6c9d412 to
a7224e4
Compare
|
@raphaelpclt finally ready. Sorry for the CI overload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281 after I got verbal approval from @RemiSoummer.
This removes the hardware service, simulated service, proxy, and their documentation. Also removes them from imports and the package entry points.
Todo
bmc_dmproxy used in testing:catkit2/tests/config/services.yml
Line 4 in 9a8777e