Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs data menu #3427

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

camipacifici
Copy link
Contributor

@camipacifici camipacifici commented Feb 3, 2025

Updated screenshots with the new data menu.

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@camipacifici
Copy link
Contributor Author

Open questions:

  • is the orange an ok color?
  • should the same labels be copied on the flux viewer for cubeviz?

@pllim pllim added this to the 4.2 milestone Feb 3, 2025
@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (c72d6f2) to head (ec007b7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3427   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         128      128           
  Lines       19957    19962    +5     
=======================================
+ Hits        17469    17474    +5     
  Misses       2488     2488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gibsongreen
Copy link
Contributor

gibsongreen commented Feb 5, 2025

  • is the orange an ok color?

I do like the orange it does play nicely into the color them of the app and I think there is enough contrast with light mode browser that it shouldn't be an issue reading. The color theme for labels as such are already discontinuous in the documentation so I don't see an issue updating to orange as it is a continuous them for the different config toolbars.

  • should the same labels be copied on the flux viewer for cubeviz?

The Display Settings might be tricky to fit in, but I do like the idea of adding it to both. I think it is comprehensible as is but would solidify to the users that the flux and uncertainty viewers have the same tools without having to make the connection themselves.

Everything else looks good in the PR, so I'll wait to hear back and test once more locally before approving if there is an update made to any of the images.

@camipacifici
Copy link
Contributor Author

Better? Or too crowded now? Happy to iterate again.

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the updates look good, and I like the location of the for "Data Selector" with the old Data Menu!

@camipacifici
Copy link
Contributor Author

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants