Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Sonified layer in flux viewer #3430

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

javerbukh
Copy link
Contributor

Description

This pull request is a proof-of-concept for creating a new image layer when sonifying a cube. Each pixel maps to a unique integer which then maps to a sound.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added no-changelog-entry-needed changelog bot directive proof-of-concept Proof of concept for future reference labels Feb 7, 2025
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Feb 7, 2025
@javerbukh javerbukh added this to the 4.2 milestone Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 24.32432% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (329c969) to head (7e412c1).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/cubeviz/plugins/viewers.py 24.32% 28 Missing ⚠️

❌ Your patch check has failed because the patch coverage (24.32%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   87.51%   87.42%   -0.10%     
==========================================
  Files         128      128              
  Lines       19901    19995      +94     
==========================================
+ Hits        17417    17481      +64     
- Misses       2484     2514      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations proof-of-concept Proof of concept for future reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant