Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #3485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CODEOWNERS #3485

wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 5, 2025

Description

This pull request is to update codeowners file.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 5, 2025
@pllim pllim added this to the 4.2 milestone Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (112989e) to head (ee548ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3485   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         152      152           
  Lines       20743    20743           
=======================================
  Hits        18217    18217           
  Misses       2526     2526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cshanahan1
Copy link
Contributor

:(

@kecnry
Copy link
Member

kecnry commented Mar 5, 2025

No one wants to be the approver 😂 . Throw an -rf in that branch label and use admin rights to merge without an approval 😜

@camipacifici
Copy link
Contributor

Definitely not approving this one :(

@pllim
Copy link
Contributor Author

pllim commented Mar 5, 2025

Haha, you all... 😅

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=(

@pllim
Copy link
Contributor Author

pllim commented Mar 13, 2025

Awww. You don't have to merge right away but probably should after Apr 7.

@rosteen rosteen modified the milestones: 4.2, 4.3 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants