Skip to content

Add test coverage for specreduce error propogation#4047

Open
cshanahan1 wants to merge 2 commits intospacetelescope:mainfrom
cshanahan1:spec-extract-uncert
Open

Add test coverage for specreduce error propogation#4047
cshanahan1 wants to merge 2 commits intospacetelescope:mainfrom
cshanahan1:spec-extract-uncert

Conversation

@cshanahan1
Copy link
Contributor

@cshanahan1 cshanahan1 commented Feb 24, 2026

(Note: uncertainties will be available in 1.8.0 which isn't out yet, so this has a minimum version check and tests can be run locally with specreduce dev)

This PR adds test coverage for propagation of uncertainties through specreduce background and extraction steps, which was recently implemented in specreduce.

It turns out that this works right out of the box, and the returned background/extractions already have uncertainties attached, so this is just adding test coverage for the 2d case. The tests here are identical to the tests in specreduce, but go through the plugin to ensure the results are the same.

(I also snuck in a change to switch one of the existing tests for spectral extraction unit conversion from specviz2d to deconfigged)

@cshanahan1 cshanahan1 added the no-changelog-entry-needed changelog bot directive label Feb 24, 2026
@github-actions github-actions bot added plugin Label for plugins common to multiple configurations specviz2d and removed no-changelog-entry-needed changelog bot directive labels Feb 24, 2026
@cshanahan1 cshanahan1 added this to the 4.6 milestone Feb 24, 2026
@cshanahan1 cshanahan1 added no-changelog-entry-needed changelog bot directive labels Feb 24, 2026
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the new tests pass locally with dev specreduce, approved.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (50558dd) to head (f6fda92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
- Coverage   84.61%   84.61%   -0.01%     
==========================================
  Files         202      202              
  Lines       28748    28748              
==========================================
- Hits        24326    24325       -1     
- Misses       4422     4423       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations specviz2d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants