Add test coverage for specreduce error propogation#4047
Open
cshanahan1 wants to merge 2 commits intospacetelescope:mainfrom
Open
Add test coverage for specreduce error propogation#4047cshanahan1 wants to merge 2 commits intospacetelescope:mainfrom
cshanahan1 wants to merge 2 commits intospacetelescope:mainfrom
Conversation
d7d2c52 to
808e28b
Compare
rosteen
approved these changes
Feb 25, 2026
Collaborator
rosteen
left a comment
There was a problem hiding this comment.
I confirmed that the new tests pass locally with dev specreduce, approved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 84.61% 84.61% -0.01%
==========================================
Files 202 202
Lines 28748 28748
==========================================
- Hits 24326 24325 -1
- Misses 4422 4423 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Note: uncertainties will be available in 1.8.0 which isn't out yet, so this has a minimum version check and tests can be run locally with specreduce dev)
This PR adds test coverage for propagation of uncertainties through specreduce background and extraction steps, which was recently implemented in specreduce.
It turns out that this works right out of the box, and the returned background/extractions already have uncertainties attached, so this is just adding test coverage for the 2d case. The tests here are identical to the tests in specreduce, but go through the plugin to ensure the results are the same.
(I also snuck in a change to switch one of the existing tests for spectral extraction unit conversion from specviz2d to deconfigged)