refactor: necessary refactoring of pyproject.toml#1232
refactor: necessary refactoring of pyproject.toml#1232thePromger wants to merge 2 commits intosparckles:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✨ No files to analyze in this PR. Need help? Join our Discord for support! |
|
@sansyrox |
|
Did these change, because i saw in many big projects that they dont put upper bound limit for deps instead they just define lower bound limit supported, later i am able to understand the reason little bit. |
|
@thePromger , update them here :D |
pyproject.toml
Outdated
| # conditional | ||
| "uvloop~=0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'", | ||
| "watchdog == 4.0.1", | ||
| "uvloop >= 0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'", |
There was a problem hiding this comment.
can i know the reason behing it?
bcoz if we dont pin so pip will automatically do install correct version according to host pc requirements
pyproject.toml
Outdated
| "inquirerpy >= 0.3.4", | ||
| "multiprocess >= 0.70.14", | ||
| "orjson >= 3.11.0", | ||
| "rustimport >= 1.3.4", |
There was a problem hiding this comment.
let's pin the latest working versions
There was a problem hiding this comment.
bro
i dont think that we should pin them, i saw fastapi, django, pandas, polars all are have specified requirement constraint as <= not like ==.
if we pin (==) then we need to update it regularly and if we just specify minimum version supported/required then if some breaking changes come to the dependency being in used, then only we need to fix that by finding work around or just limit to previous versions before the version which has breaking changes
|
@sansyrox
what i am able to understand that this 25% performance drop is due to because we unpin the exact version, which allows pip to use latest version supported by host requirements let me test some senarious in robyn's CI inside this PR itself |
|
@sansyrox |
5fb08e0 to
0472e42
Compare
* Adds requires-python tag/attributes which helps users+build_tool/pip to find minimum version supported * Changes version constraint from exact to lowest version supported to be used
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds requires-python tag/attributes which helps users+build_tool/pip to find minimum version supported
Changes version constraint from exact to lowest version supported to be used
Adding uv.lock file to be used in CI/CD or for development by some other maintainers
PR Checklist
Please ensure that:
Pre-Commit Instructions: