Login reg #7
Open
Login reg #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth.js has logic constants has the flow
lumiscript
requested changes
Jul 2, 2018
| <p className="App-intro"> | ||
| To get started, edit <code>src/App.js</code> and save to reload. | ||
| </p> | ||
| <button type="button" className="form-submit" onClick={this.handleLogout}>Logout</button> |
There was a problem hiding this comment.
Are you sure this onClick event triggers the handleLogout method? you need to bind it .
| @@ -0,0 +1,99 @@ | |||
| import decode from 'jwt-decode'; | |||
|
|
|||
| export default class AuthService { | |||
There was a problem hiding this comment.
If you have your AuthService class setup to handle authentication then you should use it for your App component (handleLogout)
|
add the auth and binded the handleLogout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit is to review the login and register page for the app
thing to note :