[V6] Register OctaneReloadPermissions listener for Laravel Octane #2403

erikn69 · 2023-04-13T23:10:02Z

i'm not 100% sure on this
i can't test octane

this was a test for octane users to try but no one gave me feedback that it works

On #2322 (comment) was said that the problem was the spatie/once package, and that spatie/laravel-permission works correctly on octane

I recommend not merging it until you do more testing that it's the correct approach.

drbyte · 2023-04-13T23:43:46Z

I recommend not merging it until you do more testing that it's the correct approach

Agreed. I more just wanted it here as an easy place to reference the specific proposed fix. And if it's deemed "right" and not problematic, it's a simple thing then to merge it.
Thanks!

drbyte · 2023-04-13T23:46:37Z

@sweebee Are you able to test this? In reference to your issue #2401

sweebee · 2023-04-14T09:07:17Z

@drbyte Yes, its working!

davidjr82 · 2023-04-14T18:17:18Z

This solution will reload the permissions in every single tick of the octane server. Wouldn't this result in a drop of performance?

Also, we should make (I don't know how...) a test case where we can see it failing without this change, otherwise it wouldn't add anything.

drbyte · 2023-04-14T21:33:51Z

This solution will reload the permissions in every single tick of the octane server. Wouldn't this result in a drop of performance?

@sweebee Do you mind testing what benefits or drawbacks occur if not registering it with the Tick events?

Also, we should make (I don't know how...) a test case where we can see it failing without this change, otherwise it wouldn't add anything.

@sweebee Any thoughts on how best to automate such tests?

src/PermissionServiceProvider.php

drbyte · 2023-04-18T21:20:55Z

@sweebee @davidjr82 does the change to listening on OperationTerminated work satisfactorily in your app?

davidjr82 · 2023-04-19T03:26:11Z

For me the issue was in a different package (spatie/once) so this package worked without any change.

parallels999 · 2023-04-19T13:38:11Z

this package worked without any change.
this result in a drop of performance

it would be better to make it optional, so, can be activated from permission.php for whoever needs it
Like

/*
 * When set to true, the Spatie\Permission\Listeners\OctaneReloadPermissions listener will be registered
 * on the Laravel\Octane\Events\OperationTerminated event, this will refresh permissions on every
 * TickTerminated, TaskTerminated and RequestTerminated
 */
'register_octane_permissions_refresh' => true,

davidjr82 · 2023-04-20T17:01:11Z

this package worked without any change.
this result in a drop of performance

it would be better to make it optional, so, can be activated from permission.php for whoever needs it
Like
/*
 * When set to true, the Spatie\Permission\Listeners\OctaneReloadPermissions listener will be registered
 * on the Laravel\Octane\Events\OperationTerminated event, this will refresh permissions on every
 * TickTerminated, TaskTerminated and RequestTerminated
 */
'register_octane_permissions_refresh' => true,

I agree on this, although I wouldn't push a feature without a working test.

But if in this case we don't know how to do it, at least make it optimal sounds reasonable to me.

erikn69 · 2023-04-26T16:07:13Z

it would be better to make it optional

that could also apply

drbyte · 2023-04-26T17:41:42Z

I'm in agreement with adding a config switch. Just undecided about the best name for it.
The variant I'm contemplating is register_octane_reset_listener

drbyte · 2023-04-26T17:43:43Z

adding tests

I agree: it would be preferable to get some tests set up for Octane. #HelpWanted

drbyte · 2023-06-17T17:51:11Z

@freekmurze do you have a preference on incorporating tests for this?

jihadismail8 · 2024-07-08T18:30:08Z

for some reason Spatie Permissions , gives me an error of not enough permissions after ~14 requests in a row under Octane RoadRunner !! ""message": "User does not have the right permissions. Necessary permissions are Manage Permissions"," , even thought the 13 requests where fine , then sudden not enough permission , tried almost everything , and i have the last version of laravel 11 , fresh spatie Permission .... here is the trace " "trace": [
{
"file": "/var/www/html/vendor/spatie/laravel-permission/src/Middleware/PermissionMiddleware.php",
"line": 36,
"function": "forPermissions",
"class": "Spatie\Permission\Exceptions\UnauthorizedException",
"type": "::"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Spatie\Permission\Middleware\PermissionMiddleware",
"type": "->"
},
{
"file": "/var/www/html/app/Http/Middleware/Cors.php",
"line": 23,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "App\Http\Middleware\Cors",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php",
"line": 50,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Routing\Middleware\SubstituteBindings",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php",
"line": 64,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Auth\Middleware\Authenticate",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 119,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php",
"line": 805,
"function": "then",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php",
"line": 784,
"function": "runRouteWithinStack",
"class": "Illuminate\Routing\Router",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php",
"line": 748,
"function": "runRoute",
"class": "Illuminate\Routing\Router",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php",
"line": 737,
"function": "dispatchToRoute",
"class": "Illuminate\Routing\Router",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php",
"line": 200,
"function": "dispatch",
"class": "Illuminate\Routing\Router",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 144,
"function": "Illuminate\Foundation\Http\{closure}",
"class": "Illuminate\Foundation\Http\Kernel",
"type": "->"
},
{
"file": "/var/www/html/vendor/livewire/livewire/src/Features/SupportDisablingBackButtonCache/DisableBackButtonCacheMiddleware.php",
"line": 19,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Livewire\Features\SupportDisablingBackButtonCache\DisableBackButtonCacheMiddleware",
"type": "->"
},
{
"file": "/var/www/html/vendor/barryvdh/laravel-debugbar/src/Middleware/InjectDebugbar.php",
"line": 66,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Barryvdh\Debugbar\Middleware\InjectDebugbar",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php",
"line": 21,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php",
"line": 31,
"function": "handle",
"class": "Illuminate\Foundation\Http\Middleware\TransformsRequest",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php",
"line": 21,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php",
"line": 51,
"function": "handle",
"class": "Illuminate\Foundation\Http\Middleware\TransformsRequest",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Foundation\Http\Middleware\TrimStrings",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php",
"line": 27,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Http\Middleware\ValidatePostSize",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php",
"line": 110,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php",
"line": 62,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Http\Middleware\HandleCors",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php",
"line": 57,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 183,
"function": "handle",
"class": "Illuminate\Http\Middleware\TrustProxies",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php",
"line": 119,
"function": "Illuminate\Pipeline\{closure}",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php",
"line": 175,
"function": "then",
"class": "Illuminate\Pipeline\Pipeline",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php",
"line": 144,
"function": "sendRequestThroughRouter",
"class": "Illuminate\Foundation\Http\Kernel",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/octane/src/ApplicationGateway.php",
"line": 36,
"function": "handle",
"class": "Illuminate\Foundation\Http\Kernel",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/octane/src/Worker.php",
"line": 84,
"function": "handle",
"class": "Laravel\Octane\ApplicationGateway",
"type": "->"
},
{
"file": "/var/www/html/vendor/laravel/octane/bin/roadrunner-worker",
"line": 54,
"function": "handle",
"class": "Laravel\Octane\Worker",
"type": "->"
},
{
"file": "/var/www/html/vendor/bin/roadrunner-worker",
"line": 119,
"function": "include"
} "

jihadismail8 · 2024-07-08T18:30:48Z

forgot to add that in php artisan serve , it works fine

jihadismail8 · 2024-07-08T18:42:06Z

ok found the problem , it was because of teams , since teams is being flushed the Users loses permissions
that creates a dilemma now

parallels999 mentioned this pull request Apr 14, 2023

Laravel octane random results when using Auth::user()->can('permisssion') after modifying role/permission belonging #2322

Closed

erikn69 force-pushed the patch-3 branch from 74f4f3d to 72f5635 Compare April 14, 2023 15:56

erikn69 changed the title ~~Register OctaneReloadPermissions listener for Laravel Octane~~ [V6] Register OctaneReloadPermissions listener for Laravel Octane Apr 14, 2023

drbyte linked an issue Apr 14, 2023 that may be closed by this pull request

Wrong permissions on refresh (Vapor/Octane) #2401

Closed

erikn69 force-pushed the patch-3 branch from 72f5635 to 592d0fd Compare April 14, 2023 22:52

drbyte reviewed Apr 18, 2023

View reviewed changes

src/PermissionServiceProvider.php Outdated Show resolved Hide resolved

erikn69 force-pushed the patch-3 branch from 592d0fd to 4cbfc19 Compare April 18, 2023 20:42

Register OctaneReloadPermissions listener for Laravel Octane

7074193

erikn69 force-pushed the patch-3 branch from 3ef2a6f to 7074193 Compare April 26, 2023 18:58

drbyte requested a review from freekmurze June 17, 2023 17:51

drbyte added 2 commits July 13, 2023 23:02

Merge branch 'main' into patch-3

e1e9069

Add note to config file

d398680

drbyte merged commit feb3014 into spatie:main Aug 17, 2023
20 checks passed

erikn69 mentioned this pull request Nov 9, 2023

Reset teamId on octane #2547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[V6] Register OctaneReloadPermissions listener for Laravel Octane #2403

[V6] Register OctaneReloadPermissions listener for Laravel Octane #2403

erikn69 commented Apr 13, 2023 •

edited by drbyte

Loading

drbyte commented Apr 13, 2023

drbyte commented Apr 13, 2023

sweebee commented Apr 14, 2023

davidjr82 commented Apr 14, 2023

drbyte commented Apr 14, 2023

drbyte commented Apr 18, 2023

davidjr82 commented Apr 19, 2023

parallels999 commented Apr 19, 2023 •

edited

Loading

davidjr82 commented Apr 20, 2023

erikn69 commented Apr 26, 2023

drbyte commented Apr 26, 2023

drbyte commented Apr 26, 2023

drbyte commented Jun 17, 2023

jihadismail8 commented Jul 8, 2024

jihadismail8 commented Jul 8, 2024

jihadismail8 commented Jul 8, 2024

[V6] Register OctaneReloadPermissions listener for Laravel Octane #2403

[V6] Register OctaneReloadPermissions listener for Laravel Octane #2403

Conversation

erikn69 commented Apr 13, 2023 • edited by drbyte Loading

drbyte commented Apr 13, 2023

drbyte commented Apr 13, 2023

sweebee commented Apr 14, 2023

davidjr82 commented Apr 14, 2023

drbyte commented Apr 14, 2023

drbyte commented Apr 18, 2023

davidjr82 commented Apr 19, 2023

parallels999 commented Apr 19, 2023 • edited Loading

davidjr82 commented Apr 20, 2023

erikn69 commented Apr 26, 2023

drbyte commented Apr 26, 2023

drbyte commented Apr 26, 2023

drbyte commented Jun 17, 2023

jihadismail8 commented Jul 8, 2024

jihadismail8 commented Jul 8, 2024

jihadismail8 commented Jul 8, 2024

erikn69 commented Apr 13, 2023 •

edited by drbyte

Loading

parallels999 commented Apr 19, 2023 •

edited

Loading