Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contracts to allow for UUID #2480

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Conversation

drbyte
Copy link
Collaborator

@drbyte drbyte commented Aug 19, 2023

Must allow for string to $id parameter.

Also updated syntax to declare $guardName as nullable string.

/cc @erikn69

@erikn69
Copy link
Contributor

erikn69 commented Aug 21, 2023

Looks great to me,
it's a breaking change, but it's a major version, so 👍

#2089

Maybe change data type on findById is a breaking change for somebody overwriting that function,
if that is true, maybe for V6 release

@parallels999
Copy link
Contributor

If you drop Php7.4 you could use Union Types on findbyId

@drbyte
Copy link
Collaborator Author

drbyte commented Aug 21, 2023

If you drop Php7.4 you could use Union Types on findbyId

Ya, I was itching for that too.

@parallels999
Copy link
Contributor

parallels999 commented Aug 21, 2023

Time to drop it
image

@drbyte
Copy link
Collaborator Author

drbyte commented Aug 21, 2023

Alright. Given that I'd like to avoid changing contracts again, if possible, using Union Types now saves that pain.

@drbyte drbyte merged commit 4cb4594 into spatie:main Aug 21, 2023
18 checks passed
@drbyte drbyte deleted the update_contracts branch August 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants