-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contracts to allow for UUID #2480
Conversation
Also updates to declare `?string` as `$guardName` signature
Looks great to me,
|
If you drop Php7.4 you could use Union Types on findbyId |
Ya, I was itching for that too. |
Alright. Given that I'd like to avoid changing contracts again, if possible, using Union Types now saves that pain. |
Must allow for
string
to$id
parameter.Also updated syntax to declare
$guardName
as nullable string./cc @erikn69