Add Chinese translation for models - Part IV #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Chinese translation for Extension, Licensing, Lite and Security models Signed-off-by: Zhenyu Zheng <[email protected]>
bact
requested changes
Jan 4, 2025
Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: Zhenyu Zheng <[email protected]>
bact
approved these changes
Jan 5, 2025
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
The translation maintains the essence of the source material while adapting naturally to Chinese. No issues spotted. |
|
LGTM. The translation is excellent. It is clear that the technical understanding is correct and the language is used appropriately. A rare and outstanding translation! |
|
The zh-Hans version LGTM. The content is well-organized and flows naturally, adhering to Chinese grammar and language conventions. It reads smoothly, and the structure is clear and easy to follow. |
|
With @LiuPeng-running, @gomico, and @helen-ls approvals here and with a decision at #949 (comment), I will merge this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chinese translation for Extension, Licensing, Lite and Security models