-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Software: Add sizeInBytes in field #966
base: develop
Are you sure you want to change the base?
Conversation
4b215af
to
8208b8b
Compare
Two things:
|
Ya, 0 bytes makes sense, so we should change that. |
Why not simply call it |
8208b8b
to
3e5aa9f
Compare
Adds a property to software Artifact that indicates the size, in bytes Signed-off-by: Joshua Watt <[email protected]>
3e5aa9f
to
03d1ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in agreement to add this field in software profile and remove from datasets. I like the new name of field, better than with bytes in the field name. You might want to put in examples of how to fill in this field. I approve the change and for 3.1 we add a PR to remove similar field from dataset profile.
@bennetkl for backward compatibility with 3.0.x, I don't think we can remove datasetSize from the spec. We can however deprecate it, put some description encouraging people to use the new artifactSize, also maybe considering putting a A 3.0 to 3.1 migration tool can also help users convert this. |
Adds a property to software Artifact that indicates the size, in bytes