fix(dashboard): correct side nav badge sizing - #3180
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3d8dbfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 5 files
Linked issue analysis
Linked issue: AGE-2644: bug: side nav issue with badges
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Update @speakeasy-api/moonshine to 1.40.0 so the library size prop can be used | package.json and pnpm-lock.yaml show the dependency bumped to 1.40.0, enabling the library Badge size prop used elsewhere. |
| ✅ | Remove manual badge scaling/negative margins at side-nav call sites (drop scale-75, -my-1 and size="xs" on call sites) | nav-menu.tsx and ObserveTabNav no longer pass size="xs" and have removed classes like 'scale-75' and '-my-1' from ReleaseStageBadge call sites. |
| ✅ | Standardize internal ReleaseStageBadge to use Badge size="sm" (use library size prop internally) | release-stage-badge.tsx now sets Badge size="sm" internally and the size prop was removed from the component API. |
| ✅ | Replace arbitrary Tailwind z-index classes with z-1 in nav items | nav-menu.tsx replaces occurrences of 'z-[1]' with 'z-1', removing arbitrary inline z-index values. |
| ✅ | Side-nav label truncation is resolved (text has the space it needs when badges are present) | The PR removes the manual transforms and sets a consistent library badge size that directly addresses the truncation root cause described in the issue; the code changes necessary for the fix are present in the diff. |
2 tasks
simplesagar
approved these changes
Jun 3, 2026
removes scale transform that was causing spacing calculation issues
…abels render consistently in side nav and tab navigation.
alx-xo
force-pushed
the
alexm/age-2644-bug-side-nav-issue-with-badges
branch
from
June 4, 2026 18:31
8d9c83e to
3d8dbfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseStageBadgesize call site.Root Cause
The use of scale-75 had an unintended side effect with flex spacing and truncation. It would hold the space of the full size of the badge. Even with it smaller it would cause truncation to kick in for nav items. This was surfaced when Device Agent is added.
Realated PR
Test Plan
pnpm -F dashboard type-checkpnpm -F dashboard lintSummary by cubic
Fixes release-stage badge sizing in the side nav and Observe tabs so preview/beta labels render consistently and no longer cause text truncation. Addresses Linear AGE-2644.
Badgewithsize="sm".sizeprop fromReleaseStageBadgeand delete call-site usages in side nav andObserveTabNav.z-[1]withz-1on nav links.Written for commit 3d8dbfe. Summary will update on new commits.