fix(acp): unify autonomous turn lifecycle - #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate user-initiated and autonomous ACP v2 turn draining behind one shared lifecycle. Background-task and MCP continuations now publish
RunningandIdle, allowing clients to steer the active model turn instead of attempting a conflicting prompt.Motivation
Autonomous continuations previously held the session busy without updating ACP foreground state. The TUI therefore appeared idle and submitted new prompts, which the server rejected as internal errors until the continuation completed.
Impact
Messages submitted while Kit synthesizes a background result are now admitted as steering input. Autonomous completion, cancellation, and error paths also expose the same state transitions and stop reasons as user-initiated turns.
Technical details
Shared turn lifecycle
Prompt-specific request admission and user-message publication remain separate. Once input is admitted, both prompt and autonomous paths use the same turn runner for state publication, loop draining, cancellation, background settlement, update flushing, diagnostics, and terminal state.
Autonomous admission
drive_autonomousis reduced to claiming the session, preparing injection, invoking the shared runner, and releasing the session. This keeps background and MCP input semantics distinct without duplicating the active-turn lifecycle.