Skip to content

fix(factory): make artifact inspection deterministic - #184

Merged
walker-tx merged 1 commit into
mainfrom
feat/kit-guide-factory
Aug 28, 2026
Merged

fix(factory): make artifact inspection deterministic#184
walker-tx merged 1 commit into
mainfrom
feat/kit-guide-factory

Conversation

@walker-tx

Copy link
Copy Markdown
Member

Summary

  • add a deterministic, fail-closed guide artifact inspector for research, writer, and revision phases
  • require exact phase-local helper commands and exact minimal JSON validation in the coordinator
  • reject unsafe slugs/stages, symlinks, incomplete phase artifacts, and unexpected target files
  • cover resumed four-file research and missing writer/revision artifacts

Root cause

Run 33194060085 passed the cosmetic-UI policy but failed when the coordinator improvised physical writer-artifact checks. This removes that model-invented validation point.

Verification

  • GOFLAGS='-ldflags=-linkmode=external' bash factory/tests/run.sh (12/12 tests)
  • mise x shellcheck@0.10.0 -- shellcheck factory/scripts/*.sh factory/tests/*.sh
  • git diff --check
  • independent review: no findings

@walker-tx
walker-tx force-pushed the feat/kit-guide-factory branch from 75a2c69 to 2cf4f9d Compare August 28, 2026 17:52
@walker-tx
walker-tx merged commit ac8459f into main Aug 28, 2026
1 check passed
@walker-tx
walker-tx deleted the feat/kit-guide-factory branch August 28, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant