Skip to content

fix(factory): isolate runtime projection failures - #188

Merged
walker-tx merged 1 commit into
mainfrom
fix/kit-diagnostics-noninterference
Aug 28, 2026
Merged

fix(factory): isolate runtime projection failures#188
walker-tx merged 1 commit into
mainfrom
fix/kit-diagnostics-noninterference

Conversation

@walker-tx

Copy link
Copy Markdown
Member

Summary

  • keep strict runtime-event projection fail-closed
  • prevent diagnostics projection failure from replacing a valid Kit/report outcome
  • omit diagnostics after rejected projection while preserving ordinary stderr and suppressing marked records

Root cause

Box run 33207230591 reached Run Kit, then the projector rejected its marked stream. The entrypoint unconditionally exited 1 before evaluating the real Kit/report result, so observability could fail the factory.

Testing

  • bash factory/tests/test-container.sh
  • GOFLAGS='-ldflags=-linkmode=external' bash factory/tests/run.sh (13/13)
  • mise x shellcheck@0.10.0 -- shellcheck factory/scripts/.sh factory/tests/.sh
  • mise x actionlint@1.7.7 shellcheck@0.10.0 -- actionlint .github/workflows/guide-draft.yml
  • git diff --check

Security

Malformed, unknown, and over-cap marked streams are still drained, suppressed, and removed with only the fixed safe error. No rejected diagnostics artifact is built or uploaded.

@walker-tx
walker-tx merged commit 06c2e45 into main Aug 28, 2026
1 check passed
@walker-tx
walker-tx deleted the fix/kit-diagnostics-noninterference branch August 28, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant