This repository was archived by the owner on Jul 31, 2026. It is now read-only.
feat: app layout - #260
Merged
Merged
Conversation
farazcsk
reviewed
Aug 4, 2025
| background-color: var(--color-neutral-100); | ||
|
|
||
| @variant dark { | ||
| background-color: var(--color-neutral-900); |
Contributor
There was a problem hiding this comment.
Nice, really I want to move all the utilities to be defined this way instead of how we have it now where there is a variable for each one.
Member
Author
There was a problem hiding this comment.
Yeah tbh i found that tokens file a bit of a mess - we should rationalize it in our meeting tomorrow!
farazcsk
approved these changes
Aug 4, 2025
farazcsk
left a comment
farazcsk
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's tighten when it's in the sandbox
| @@ -0,0 +1,287 @@ | |||
| import { cn } from '@/lib/utils' | |||
Contributor
There was a problem hiding this comment.
Nice appreciate the declarative apis here
We might be able to make some of the validation easier by using https://www.radix-ui.com/primitives/docs/utilities/slot in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.