Skip to content
This repository was archived by the owner on Jul 31, 2026. It is now read-only.

feat: mark as tree-shakable #311

Merged
danielkov merged 1 commit into from
Oct 20, 2025
Merged

feat: mark as tree-shakable #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "1.9.1",
"packageManager": "pnpm@9.0.0",
"description": "Speakeasy's design system Moonshine",
"sideEffects": false,

@cursor cursor Bot Oct 20, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CSS Exports Require sideEffects: true

Setting sideEffects: false in package.json is incorrect for a package that exports CSS files. CSS imports have global side effects, so bundlers may incorrectly tree-shake them, potentially causing missing styles in production builds.

Fix in Cursor Fix in Web

@danielkov danielkov Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also concerned by this, but based on our usage and the README:

### 2. Configure Tailwind CSS

Add this to the top of your project's CSS file where you configure Tailwind:

```css
/* This must come BEFORE your Tailwind imports */
@reference "../node_modules/@speakeasy-api/moonshine/src/global.css";

We shouldn't depend on CSS-injection from JS.

Also possible to do "sideEffects": ["*.css"].

"main": "dist/moonshine.cjs.js",
"module": "dist/moonshine.es.js",
"types": "dist/index.d.ts",
Expand Down
Loading