This repository was archived by the owner on Jul 31, 2026. It is now read-only.
feat(formatting): switch prettier to oxfmt - #352
Merged
Conversation
There was a problem hiding this comment.
4 issues found across 244 files
Confidence score: 3/5
- There is a concrete user-facing behavior risk in
src/components/SegmentedButton/index.tsx:enhancedChildrenmemoization omitshoveredId, so highlighted state can become stale after interaction. - Accessibility is also impacted in
src/components/WorkspaceSelector/SearchBox.tsxbecause the icon-only clear button lacks an accessible name (aria-label), which can make the control unclear for assistive technology users. - Given the medium-severity interaction bug (6/10, high confidence) plus an accessibility issue, this carries some merge risk rather than being a clean low-risk merge.
- Pay close attention to
src/components/SegmentedButton/index.tsx,src/components/WorkspaceSelector/SearchBox.tsx,src/components/Table/context/tableProvider.tsx, andsrc/components/LanguageIndicator/index.tsx- fix stale memo state first, then address accessibility and minor cleanup issues.
Partial review: This PR has more than 100 files, so cubic reviewed the highest-priority files first.
For a deeper review of large PRs, comment @cubic-dev-ai ultrareview. Learn more.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
6 issues found across 244 files
Confidence score: 3/5
src/components/ExternalPill/index.tsxopens external links with_blankbut withoutrel="noopener noreferrer", which leaves a concrete reverse-tabnabbing hole if a linked page is malicious. Add therelattributes before merging to close the security gap.src/components/Tabs/index.tsxandsrc/components/AppLayout/useAppLayoutKeys.tsboth have state-selection/toggle edge cases (||fallback and captured!collapsed) that can mis-handle valid tab IDs or drop rapid keyboard toggles, leading to inconsistent UI behavior. Switch to nullish coalescing for tab fallback and a functional state updater for collapse toggles before merge.src/components/KeyHint/index.tsxuses a clickabledivfor dismiss, so keyboard and assistive-technology users may be unable to trigger the action reliably. Replace it with a semanticbutton(or equivalent keyboard-complete control) before merging.src/components/KeyHint/index.tsxandsrc/components/UserAvatar/index.tsxinclude smaller rendering correctness issues (keyless mapped fragments and possibleundefinedfallback colors for non-letter initials) that can produce warnings or visual glitches in edge cases. Add stable keys and guard the color index calculation to de-risk UI polish regressions.
Tip: instead of fixing issues one by one fix them all with cubic
Partial review: This PR has more than 100 files, so cubic reviewed the highest-priority files first.
For a deeper review of large PRs, comment @cubic-dev-ai ultrareview. Learn more.
Re-trigger cubic
alx-xo
force-pushed
the
alexm/feat-switch-prettier-oxfmt
branch
from
June 11, 2026 20:09
9c43059 to
0097d60
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A prelude to moving into gram repo. Align our formatting deps and config
Cubic found some preexisting bugs but in the intertest of keeping this PR aligned going to move those to it's own PR. #353
Test Plan