Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterate through all releases to try to find the right version #79

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

chase-crumbaugh
Copy link
Member

Currently, if an action is pinned to an old release of the CLI, we might not find on it and erroneously fail. This is because we only check the first page of results from github (30). This PR adds functionality to check all pages of results before failing (thread)

@chase-crumbaugh chase-crumbaugh requested a review from a team as a code owner January 4, 2024 23:56
@TristanSpeakEasy
Copy link
Member

LGTM

@TristanSpeakEasy TristanSpeakEasy merged commit 1641250 into main Jan 5, 2024
1 check passed
@TristanSpeakEasy TristanSpeakEasy deleted the chase/releases-pagination branch January 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants