feat: route cli generation through openapi-generation-next - #2110
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
2ynn
approved these changes
Aug 10, 2026
2ynn
left a comment
Contributor
There was a problem hiding this comment.
LGTM but would recommend tightening the test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The private generator is now published from
openapi-generation-nextatv2.928.0, while the canonical module/import path must remain unchanged until the separate repository-rename migration. The CLI needs an explicit, temporary remote Go module replacement so day-to-day generator work can move to-nextwithout breaking existing imports.What changed
github.com/speakeasy-api/openapi-generation/v2 v2.928.0and route it togithub.com/speakeasy-api/openapi-generation-next/v2 v2.928.0through one exact remote replacement.generation-context v1.0.0andspeakeasy-core v0.22.2; no local filesystem dependency replacements are included.scripts/upgrade.bashinspect Go module state structurally, queryopenapi-generation-nextwhile the replacement is active, and update the require and replacement versions together.Review notes
replaceis intentional and must remain until the separately approved repository rename. Imports stay canonical.scripts/upgrade.bashis the main migration-sensitive behavior: it switches release lookup only when it detects the exact approved replacement and rejects mismatched require/replace versions.openapi-generation-nexthas completed successfully.Testing
go test ./internal/sdkgen ./internal/run ./cmd/lint ./cmd/generate -count=1go test -race ./internal/sdkgen -run 'TestWithGenerationContext' -count=1go build ./...go vet ./...go mod tidytwice with no diff;go mod verifybash -n scripts/upgrade.bash-nextreplacement.Rollout / deployment notes
GOPRIVATEandBOT_REPO_TOKENGit URL rewrite for privatespeakeasy-apimodules. Its selected-repository access toopenapi-generation-nextmust be confirmed by the PR’s hosted checks before merge.scripts/upgrade.bash, and refresh module sums.Summary by cubic
Routes CLI generation to
openapi-generation-nextwith canonical imports and makes generation license-aware (Commercial vs AGPL). Also stabilizes Windows quickstart tests by running them serially and increases CI test timeouts to 30m.New Features
github.com/speakeasy-api/openapi-generation/v2 v2.928.0togithub.com/speakeasy-api/openapi-generation-next/v2 v2.928.0via a remotereplace; imports remain canonical.generation-context v1.0.0: choose Commercial vs AGPL by access; apply to generate and cancellable runs; lint uses Direct AGPL if unauthenticated; workflow sets context from workspace or Direct; preserves cancellation; rejects partial auth; add tests for workflow and cancellable contexts.github.com/speakeasy-api/speakeasy-coretov0.22.2.Migration
replaceuntil the repository rename; imports staygithub.com/speakeasy-api/openapi-generation/v2.scripts/upgrade.bashreadsgo.modstructurally, switches release lookup toopenapi-generation-nextwhen thereplaceis active, enforces matching require/replace versions, and updates both together.Written for commit f76078e. Summary will update on new commits.