Region hatch conversions #643
Open
+148
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conversion toSpeckle and toHost for Hatches in Rhino.
New Region geometry class in the hostApps is usually called Region or Polygon (pure geometry), or Hatch ("region" with a pattern or gradient fill). The property "hasHatchPattern" on Region objects indicates which one it is. If the host app only supports one type, conversion defaults to that 1 type. Like in case with Rhino: it only supports Hatch, so any Region from Speckle is received as Hatch in Rhino.
Currently the displayValue is a list of combined boundary and loop curves. We hope that in the future the Viewer can support this geometry and create a fill in the Viewer, without the need to generate and send an extra Mesh.
Example converter data from Rhino: https://app.speckle.systems/projects/16ce7b208c/models/e9f8edeb13@8b70e50737
User Value
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist: