Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass sending IFC Projects, Sites, Buildings, and Storeys as Collections #655

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

JR-Morgan
Copy link
Member

Before, we had a one-size fits all conversion function that converted everything that wasn't geometry.

I've separated collection and data object paths to implement sending objects with the correct type, and having clarity of the structure of ifc conversion

@JR-Morgan JR-Morgan marked this pull request as draft March 6, 2025 18:49
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.66%. Comparing base (670a562) to head (e3a27d7).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #655      +/-   ##
========================================
- Coverage   8.71%   8.66%   -0.05%     
========================================
  Files        227     227              
  Lines       4374    4374              
  Branches     546     547       +1     
========================================
- Hits         381     379       -2     
- Misses      3978    3979       +1     
- Partials      15      16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant