Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions class #241

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Regions class #241

wants to merge 8 commits into from

Conversation

KatKatKateryna
Copy link
Member

@KatKatKateryna KatKatKateryna commented Mar 5, 2025

New Region class is a geometry represented by the boundary curve and inner loop curves, which hostApp turns into a planar filled geometry (or, Region). Hatch ("region" with a pattern or gradient fill) is a type of new Region class with a property "hasHatchPattern=true".

Currently the displayValue is a list of combined boundary and loop curves. We hope that in the future the Viewer can support this geometry and create a fill in the Viewer, without the need to generate and send an extra Mesh.

Example converter data from Rhino: https://app.speckle.systems/projects/16ce7b208c/models/e9f8edeb13@8b70e50737
image

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 70.73%. Comparing base (b676da4) to head (aff6347).

Files with missing lines Patch % Lines
src/Speckle.Objects/Geometry/Region.cs 0.00% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #241       +/-   ##
===========================================
+ Coverage   59.85%   70.73%   +10.88%     
===========================================
  Files         263      280       +17     
  Lines       10584    11326      +742     
  Branches     1107     1111        +4     
===========================================
+ Hits         6335     8012     +1677     
+ Misses       3989     2963     -1026     
- Partials      260      351       +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatKatKateryna KatKatKateryna marked this pull request as ready for review March 5, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant