Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more attributes #242

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Remove more attributes #242

wants to merge 17 commits into from

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock requested a review from JR-Morgan March 6, 2025 12:03
JR-Morgan
JR-Morgan previously approved these changes Mar 6, 2025
Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@clairekuang should be made aware of this change

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (375f507) to head (96822c4).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #242       +/-   ##
===========================================
+ Coverage   62.41%   72.88%   +10.46%     
===========================================
  Files         264      279       +15     
  Lines       10680    11376      +696     
  Branches     1078     1073        -5     
===========================================
+ Hits         6666     8291     +1625     
+ Misses       3740     2727     -1013     
- Partials      274      358       +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamhathcock adamhathcock marked this pull request as ready for review March 7, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants