Skip to content

[feature] Cancel SelectionPrompt on Esc (Fixes #851) - #1859

Closed
nimobit wants to merge 1 commit into
spectreconsole:mainfrom
nimobit:feature/esc-cancel-selection
Closed

[feature] Cancel SelectionPrompt on Esc (Fixes #851)#1859
nimobit wants to merge 1 commit into
spectreconsole:mainfrom
nimobit:feature/esc-cancel-selection

Conversation

@nimobit

@nimobit nimobit commented Jul 18, 2025

Copy link
Copy Markdown

Fixes #851

Changes

  • Added logic in SelectionPrompt to cancel when Escape key is pressed
  • Returns null to match expected behavior
  • Added unit test to simulate Escape key press and assert OperationCanceledException

Checklist

  • I have read the Contribution Guidelines
  • I have commented on the issue and discussed the intended changes
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • No documentation changes required

This is my first pull request to this project.
I'm open to any suggestions or feedback to improve it!

@nimobit

nimobit commented Jul 18, 2025

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@nimobit
nimobit force-pushed the feature/esc-cancel-selection branch from a094a1c to ae9be3f Compare July 18, 2025 03:11
@github-actions github-actions Bot added the ⭐ top pull request Top pull request. label Aug 23, 2025
@github-actions github-actions Bot removed the ⭐ top pull request Top pull request. label Sep 19, 2025
@patriksvensson

Copy link
Copy Markdown
Contributor

Hi!

Thanks so much for taking the time to submit this PR.
I really appreciate the contribution!

Unfortunately, I haven’t had the capacity to review this in a timely manner, and since it was opened, the repository has changed significantly. Because of that, this PR is no longer in a state where it can be reviewed or merged as-is. This is not your fault, but mine, and I'm sorry about this.

I’m going to close it for now to help keep things tidy. That said, if you’re still interested in contributing, please feel free to open a new pull request that’s up to date with the current state of the repository, and I’ll be happy to take a look when I can. I'll promise I'll do better this time around.

Thanks again for your work and for your interest in the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Esc Key to exit selection

2 participants