Fix infinite loop in TableMeasurer.CollapseWidths when wrappable columns have zero width (#2131) - #2162
Merged
patriksvensson merged 2 commits intoJul 11, 2026
Conversation
…mns collapse to zero width
Contributor
Author
|
@microsoft-github-policy-service agree |
patriksvensson
requested changes
Jul 11, 2026
Contributor
Author
|
Thanks for the feedback! Rewrote the test to use TestConsole and the public API instead of reflection. |
patriksvensson
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves an infinite loop bug within TableMeasurer.CollapseWidths that occurs when one or more wrappable columns already have a width of 0 (e.g., via GetColumnWidth() returning 0 for hidden elements) while non-wrappable columns exceed the maximum console width. This edge case causes the layout engine to freeze, blocking the rendering thread indefinitely.
Fixes #2131
Changes
The regression was rooted in the reduction loop calculation when maxColumn dropped to 0. The old logic fallback assigned a value of 1 to secondMaxColumn under certain conditions, yielding a negative columnDifference (0 - 1 = -1). Because the loop termination condition explicitly checked for columnDifference == 0, the negative value bypassed the check, keeping the while loop running forever since Ratio.Reduce cannot perform reductions with negative bounds.
To fully eliminate this lock vector, two changes were introduced to TableMeasurer.cs:
Please upvote 👍 this pull request if you are interested in it.