Feature kpoland access levels #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klpoland
added
feature
klpoland
force-pushed
the
feature-kpoland-access-levels
branch
from
819bf6a to
5871fdf
Compare
lucaspar
requested changes
Sep 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive access level system for sharing datasets and captures with different permission levels. Users can now assign "Viewer," "Contributor," or "Co-Owner" permissions to shared users and groups, providing granular control over what actions shared users can perform.
- Added three permission levels (Viewer, Contributor, Co-Owner) with specific capabilities for each
- Updated sharing UI with permission level selection and management functionality
- Refactored backend sharing logic to handle permission updates and changes
- Added extensive test coverage for permission checking and updates
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/views.py | Refactored ShareItemView to handle unified sharing operations including permission changes and removals |
| gateway/sds_gateway/users/utils.py | Updated group sharing utility to support permission levels |
| gateway/sds_gateway/templates/users/partials/share_modal.html | Enhanced UI with permission level dropdowns and Google Drive-style access controls |
| gateway/sds_gateway/static/js/userSearchComponent.js | Added permission level handling to user search and chip rendering |
| gateway/sds_gateway/static/js/permission-levels.js | New JavaScript module for permission level management and UI interactions |
| gateway/sds_gateway/static/css/permission-levels.css | Comprehensive styling for permission level components and visual feedback |
| gateway/sds_gateway/api_methods/models.py | Extended UserSharePermission model with permission checking methods and dataset author management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
klpoland
force-pushed
the
feature-kpoland-access-levels
branch
from
5871fdf to
598eca5
Compare
lucaspar
reviewed
Sep 25, 2025
lucaspar
added
the
migrations
klpoland
force-pushed
the
feature-kpoland-access-levels
branch
from
a5edfc5 to
9ed70a9
Compare
lucaspar
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains ONLY updates to the sharing mechanism, allowing users to:
Changes to write privileges on the dataset editing page are on a branch checked out from this one and can be merged into this branch when these are approved (keeping all the changes together would make this a difficult to review PR so I separated them).