Skip to content

Fix zero-blob tx check in Prague#1

Merged
spencer-tb merged 1 commit into
spencer-tb:forks/praguefrom
marioevz:fix-prague-zero-blob-check
Dec 5, 2024
Merged

Fix zero-blob tx check in Prague#1
spencer-tb merged 1 commit into
spencer-tb:forks/praguefrom
marioevz:fix-prague-zero-blob-check

Conversation

@marioevz
Copy link
Copy Markdown
Collaborator

@marioevz marioevz commented Dec 4, 2024

Fix the zero-blob check in Prague.

@spencer-tb
Copy link
Copy Markdown
Owner

spencer-tb commented Dec 5, 2024

Quote from discord response:

Thanks for pushing this to finish line 🙌
The indirect fixtures is really cool!

Its worth mentioning that I directly added tests for the zero blob case twice in ethereum/execution-spec-tests#994, and indirectly in some of the multi block tests. So with the check re-added to EELS these cases now fail. My gut says that the check shouldn't exist for Prague but happy to adapt the tests 😄

Tentative based on what you think re. the 7742 tests PR: ethereum/execution-spec-tests#994

@spencer-tb spencer-tb merged commit 51f5476 into spencer-tb:forks/prague Dec 5, 2024
spencer-tb pushed a commit that referenced this pull request May 7, 2025
* dev: change type of branch node subnodes

* Annotate tuple with 16

* add ellipsis to tuple

* explicit tuple

* use explicit 16-field tuple

* fmt

* remove Annotated import

* fix types

* Use assert_type alongside cast (#1)

* Import from typing_extensions instead of typing (#2)

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
spencer-tb pushed a commit that referenced this pull request Dec 1, 2025
…m#1666)

* refactor(tests): Refactor json_infra using `pytest_collect_file`

* fix(tests): json collecting

* fix(tests): blockchain test execution

* fix(tests): blockchain test execution

* refactor(tests): Refactor types in json_infra

* fix(tests): json_infra, imports, parse `exceptions` in some tests

* refactor(tests): move some definitions

* fix(tox.ini): Remove `--ignore-glob`

* fix(tests): workaround for FileNotFoundError

* fix(tests): revamp cache

fix(tests): Don't cache fixtures

Try to implement cache

Fix caching

feat(tests): Manage cache during execution

* fix(tox): Use `--dist=loadfile`

* fix(tests): json files cache

* Run selective tests based on changed files (#1)

* fix(tests): remove evm_tools marker from blockchain tests

* remove coverage from json_infra

* enhance(tools): add json_test_name to Hardfork

* fix(tests): handle failing transactions in state tests

* enhance(tests): add from and until fork option to json_infra

* enhance(tests): run json_infra selectively

* enhance(tests): subclass Hardfork

* bug(tests): run all tests for t8n changes

* enhance(tests): minor fix

* fix(tests): ignore expectSection tests and add coverage

* enhance(tests): refactor exception markers

This commit refactors exception markers and marks the EEST static tests as slow

* fix(tests): provide unique name to tests

* fix(tests): post review changes

* fix(tests): set BASE_SHA to merge base

---------

Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com>
Co-authored-by: Guruprasad Kamath <guru241987@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants