Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parents to use env prefix instead to avoid mixing both concepts #1617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JLugagne
Copy link

@JLugagne JLugagne commented Sep 6, 2023

In the commit 3f4449054d043e278c83a837648d882823a0a3c7 the concept of parents was added to keep track of the ancestors but led to some regressions (cf: issue 1566).

Instead of adding this new concept, why not using the envPrefix which seems to be made for this purpose? It may change Sub's behavior but makes it more intuitive I believe. And keeps the behavior defined by the TestEnvSubConfig.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@robdesbois
Copy link

@TaylorOno @sagikazarmark you co-authored the original commit - any comments on this resolution to #1566?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants