remove 'target-version' from ruff config #13517
Open
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping it set lets us decouple dropping Python versions and running eg Pyupgrade changes. |
Can you explain what you mean? I don't see how you can decouple these? |
|
Just following up on this @AA-Turner - I can't see how you can decouple pyupgrade from the 'requires python' config value (nor that would be any advantage in doing so). You cant let pyupgrade suggest syntax newer than is supported by requires-python or you invalidate it. As soon as you do upgrade requires-python, there's no reason not to take advantage of newer syntax immediately. I think accidentally misaligning the two values is a bigger risk to be honest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this value is not needed when 'requires-python' version is set in pyproject.toml