Skip to content

Fix sphinx.js discovery for when documentation source is in a subdir #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannecederberg wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix sphinx.js discovery for when documentation source is in a subdir #14160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
604e527
Fix sphinx.js discovery for cases where documentation source is in a …
jannecederberg Dec 7, 2025
b77b900
Add name to AUTHORS.rst as instructed in PR instructions
jannecederberg Dec 7, 2025
0b14eb9
Adhere to linting rules
jannecederberg Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Contributors
* Ian Lee -- quickstart improvements
* Jacob Mason -- websupport library (GSOC project)
* James Addison -- linkcheck and HTML search improvements
* Janne Cederberg -- sphinx.js discovery bug-fix
* Jeppe Pihl -- literalinclude improvements
* Jeremy Maitin-Shepard -- C++ domain improvements
* Joel Wurtz -- cellspanning support in LaTeX
Expand Down
4 changes: 3 additions & 1 deletion sphinx/builders/html/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ def create_build_info(self) -> BuildInfo:

def _get_translations_js(self) -> Path | None:
for dir_ in self.config.locale_dirs:
js_file = Path(dir_, self.config.language, 'LC_MESSAGES', 'sphinx.js')
js_file = Path(
self.srcdir, dir_, self.config.language, 'LC_MESSAGES', 'sphinx.js'
)
if js_file.is_file():
return js_file

Expand Down
Loading