release candidate - #282
Closed
v0lkan wants to merge 29 commits into
Closed
Conversation
Add context.Context parameter to all SDK API calls to enable proper request cancellation and timeout handling. This replaces the previous workaround in dispatch.go that wrapped calls in goroutines. Key changes: - All API method calls now accept context as first parameter - Remove contributeWithContext wrapper in favor of native SDK support - Move cipher helper functions (readAndGuardRequest, getCipherAndEncrypt, respond* functions) to SDK net package - Use AuthorizeAndRespondOnFailForPath for path-based authorization - Delete unused cipher state, net, and read files now handled by SDK - Remove toSecretMetadataSuccessResponse in favor of SDK's ValueToSecretMetadataSuccessResponse Signed-off-by: Volkan Özçelik <me@volkan.io>
Move defer cleanupIn() before error check to satisfy linter. The openInput function returns a no-op cleanup on error, so calling it unconditionally is safe and more defensive. Also fix indentation in encrypt_impl.go and delete.go. Signed-off-by: Volkan Özçelik <me@volkan.io>
Signed-off-by: Volkan Özçelik <me@volkan.io>
Member
Author
|
Will create a new change from main; add relevant parts and close this PR. It's a mess. and |
v0lkan
added a commit
that referenced
this pull request
Jul 14, 2026
Ports the substantive work from PR #282 (feature/review) onto current main as a single clean change, discarding that branch's WIP history. - Bump spike-sdk-go v0.17.19 -> v0.19.9 - Thread context.Context through all SDK API calls for cancellation and timeout control - Relocate cipher/net/read helpers into the SDK and delete the local copies now provided upstream - Route cipher encrypt/decrypt through net.DispatchByContentType Conflict resolutions preserve main's later features: - StoreSecret keeps secret-metadata-at-rest encryption (#277) while adopting #282's withSerializableTx structure; the DDL requires the encrypted metadata form, so the plain-column path would have broken - Policy and secret formatting keep the standardized output formats (#274), including YAML Follow-on fixes surfaced by the migration: - Drop obsolete createCipher tests (cipher creation moved to the SDK) - Track the SDK's ShardFromKeperAPIRoot -> ShardFromKeeperAPIRoot rename and its parse-error sentinel contract - Teach the route guard test to recognize DispatchByContentType delegation; authorization is unchanged, only its call site moved - Fix ST1003 naming (spifeIdPatternErr -> spifeIDPatternErr) make test and make audit both pass; govulncheck reports 0 affecting vulnerabilities. Spec: TBD Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
placeholder PR for the next release.
other outstanding PRs will be staged to be done after the release cut.