Add support for Microsoft SQL Server #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sweet! I'll look at the tests, been a while since I have ran them. What error do you get when attempting to run them? |
Owner
There was a problem hiding this comment.
We only bump this number when there is a major change in the gem, will prolly just release this as 0.5.1 :)
Owner
|
If you merge master into your branch or rebase the tests should work. Don't worry about adding any new tests as we can't run them on Travis CI anyway since they don't have a SQL Server option. If it works for you in your project thats good enough for me :) |
Owner
|
Did this end up working for you? There are more changes in the master branch of randumb that you will need to merge into your branch for tests to pass. Alternatively I can add your changes in a new branch if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to run your tests, so I have not added tests. I would be happy to do so, if I was able to run your tests.