Remove unnecessary nodejs setup - #250
Merged
itowlson merged 1 commit intoSep 1, 2026
Merged
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
marked this pull request as ready for review
August 31, 2026 06:41
karthik2804
approved these changes
Aug 31, 2026
itowlson
enabled auto-merge
August 31, 2026 19:52
Contributor
Author
|
Very weird that it always timeout without obvious issue in log... let me look into it |
Contributor
|
The link checker is pretty flaky, although GH usually kills it after 3 hours if it gets stuck (at the time I wrote this it was 5 hours and counting). But it does get stuck a lot. (Edit: completed successfully in 11 mins on the third attempt.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another workflow doesn't use setup-node, and node should come with GitHub host runner by default.
If we can remove it, we won't have to maintain the version in it.
20is currently EOL and contains multiple vulnerabilities.