Use wasip2 target in templates and examples #3258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
force-pushed
the
use-wasip2
branch
from
86cb2f5 to
f9d91c1
Compare
michelleN
requested changes
Sep 2, 2025
.github/workflows/release.yml
Outdated
| @@ -104,7 +104,7 @@ jobs: | |||
| run: rustup target add --toolchain ${{ env.RUST_VERSION }} ${{ matrix.config.target }} | |||
|
|
|||
| - name: "Install Wasm Rust target" | |||
| run: rustup target add wasm32-wasip1 wasm32-unknown-unknown --toolchain ${{ env.RUST_VERSION }} | |||
| run: rustup target add wasm32-wasip1wasm32-wasip2 wasm32-unknown-unknown --toolchain ${{ env.RUST_VERSION }} | |||
There was a problem hiding this comment.
Suggested change
| run: rustup target add wasm32-wasip1wasm32-wasip2 wasm32-unknown-unknown --toolchain ${{ env.RUST_VERSION }} | |
| run: rustup target add wasm32-wasip1 wasm32-wasip2 wasm32-unknown-unknown --toolchain ${{ env.RUST_VERSION }} |
Signed-off-by: Brian Hardock <[email protected]>
itowlson
force-pushed
the
use-wasip2
branch
from
f9d91c1 to
35f4310
Compare
|
@fibonacci1729 I fixed the typo that Michelle identified but there are still some tests failing (dependencies?). This maybe relates to the WASI 0.2.0/0.2.3 thing which I think you mentioned you were looking at upstream - is that right? |
|
Thanks! Yeah working to fix composing semver compatible versions in wac now. Ill just leave this open until I have a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.