Expand wildcard service chaining during spin up
#3266
Merged
+101
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3264.
There are several ways to approach this. I don't much love this but adopted it in order to preserve the error in app splitting scenarios.
An alternative would be to do it as part of TOML manifest normalisation before we even get to the locking stage: this would result in OCI artifacts having the wildcard pre-expanded which I dunno if it's a good thing or a bad thing or just a thing. However it would result in app splitting giving an error like "component alice service chains to component bob which doesn't exist," which seems less clear and helpful than "you can't use a wildcard if you're gonna app split."
(Note that even if we did pre-expand OCI artifacts we'd still need to either do this as well, or deal with the possibility of wildcards at run time trigger, because existing OCI artifacts could contain star chains.)
Anyway open to feedback and discussion as ever