feat(webhook): add new webhook.followRedirects property #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to pave the way for a new followRedirects config property.
Default to true so there's no behavior change. When false, don't follow redirects in webhook stages.
xibz
reviewed
Feb 16, 2025
| @@ -114,11 +114,18 @@ public ClientHttpRequestFactory webhookRequestFactory( | |||
|
|
|||
| validateResponseSize(response, webhookProperties.getMaxResponseBytes()); | |||
|
|
|||
| if (webhookProperties.isVerifyRedirects() && response.isRedirect()) { | |||
| // verify that we are not redirecting to a restricted url | |||
| if (response.isRedirect()) { | |||
There was a problem hiding this comment.
So I see we have this validateRequestSize and validateResponseSize, would it make sense to move this to a method called validateAnyRedirects?
There was a problem hiding this comment.
We didn't decide the isRedirect method name here. It's a method on the okhttp3.Response class.
We do get to decide property names though, and I figured followRedirects was consistent with the existing verifyRedirects.
There was a problem hiding this comment.
Aaah, I see...We could move all this logic to a separate method for handling redirect validation...yes, that makes sense.
xibz
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to true so there's no behavior change. When false, don't follow redirects in webhook stages.