feat(webhook): add webhook-specific configuration properties for read and connect timeout #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and connect timeout webhook.readTimeoutMs (default 20000) and webhook.connectTimeoutMs (default 15000) instead of using ok-http-client.readTimeoutMs and ok-http-client.connectTimeoutMs (same defaults). This way it's possible to configure webhook stages independently of the way spinnaker microservices communicate with each other.
…lient.connectTimeoutMs if the corresponding `webhook.` property isn't set, for backwards compatibility.
xibz
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webhook.readTimeoutMs(default 20000) andwebhook.connectTimeoutMs(default 15000).If not present, fall back to
ok-http-client.readTimeoutMsandok-http-client.connectTimeoutMs(same defaults) to mantain behavior where those ok-http-client properties are set.This way it's possible to configure webhook stages independently of the way spinnaker microservices communicate with each other.