Feat/add qr code support for sharing and joining groups#500
Open
theo-engels wants to merge 2 commits intospliit-app:mainfrom
Open
Feat/add qr code support for sharing and joining groups#500theo-engels wants to merge 2 commits intospliit-app:mainfrom
theo-engels wants to merge 2 commits intospliit-app:mainfrom
Conversation
- Add internationalization (i18n) to QrCodeScanner component using next-intl - Extract hardcoded UI strings: "Start Camera", "Stop Scanning", camera error messages - Follow existing translation conventions used in other components - Fix ShareQrCodeDialog to support multiple instances on same page - Replace hardcoded id="qr-code-svg" with per-instance unique id via useId() - Update handleDownload to reference dynamic id instead of document.getElementById() - Ensures no DOM id conflicts when multiple dialogs are rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add QR code functionality to improve group sharing and joining experience:
Add camera-based QR code scanner for joining groups
Add new dependencies:
Add translation keys for QR code UI elements
Generating a QR code can be done on desktop and mobile clients, using the same workflow as for sharing a URL, but with an additional QR code icon. Selecting this will generate the QR Code.
Generate QR Code icon
Show QR Code
For a new group member that is all that would be needed to take the user to the site and access the group. For existing Spliit users, there is also an option to aquire the URL via the QR Code and add it to their list. To go this go to the top level groups section , and select the current Add by URL button. If on a mobile device it will now offer the user to add by URL as per the current option, or via QR code, at which point it would prompt the user to
Aquire Group via QR Code
