Fix bug when pasting currency amount (parsing commas and decimals)#531
Open
Dustin-ONeil wants to merge 1 commit into
Open
Fix bug when pasting currency amount (parsing commas and decimals)#531Dustin-ONeil wants to merge 1 commit into
Dustin-ONeil wants to merge 1 commit into
Conversation
Dustin-ONeil
commented
Jun 24, 2026
Dustin-ONeil
left a comment
Author
There was a problem hiding this comment.
Reviewed for common GPT-related issues and unnecessary bloat. Let me know whether this feels lightweight enough and covers the right use cases. I’m happy to add more robust edge cases or stronger string-handling scenarios as needed.
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pasted currency values being misread when they include thousands separators.
For example,
-$1,659.84was previously normalized as-1.65984because the first separator was treated as the decimal separator. This change normalizes common US and European pasted number formats into the existing internal format: digits, optional leading-, and.as the decimal separator.Changes
normalizeNumberInputhelper-$1,659.84-€1.659,841,234,567.891.234.567,891.23and1,23Testing
npm testnpm run check-typesnpm run lintTransparency Note
This is my second small request using Codex for implementation help. I’m trying it out to see whether it improves my workflow, and I want to be transparent so reviewers can flag anything that feels off or low-quality.