-
Notifications
You must be signed in to change notification settings - Fork 27
Adding risk data model validation to integration testing #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -33,7 +34,7 @@ | |||
from contentctl.objects.risk_event import RiskEvent | |||
|
|||
# Suppress logging by default; enable for local testing | |||
ENABLE_LOGGING = False | |||
ENABLE_LOGGING = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to switch this to False.
But we should probably consider exposing ALL logging and verbosity as a common setting somewhere (possibly in contentctl.yml or the command line) since as we add more and more of it, it can be extremely useful
Also bump contentctl version for new release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made two additional small changes to bump the version and disable logging.
Given those are small changes, I will approve and merge myself.
Context
Code changes
CorrelationSearch
class which retrieves events from the risk data modelTesting
TODOs